feat: add bitwise opcodes and greater-than comparisons #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omparisons (GTI, GTS) - Add 7 new opcodes to von/cpu.go with switch case handlers - Add 7 assembler builder methods in assembler/asm.go - Add 11 new test cases for all new operations - Fix pre-existing Go 1.15+ compatibility issue in test (string conversion) - Initialize go.mod for module support
Author
Review completed. The implementation of bitwise opcodes and comparison operations looks solid with comprehensive tests. Found 1 issue that needs attention:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| module github.com/qiniu/arch | |||
|
|
|||
| go 1.25.5 | |||
Author
There was a problem hiding this comment.
Invalid Go version specified. Go versions follow the format major.minor (e.g., 1.21, 1.22, 1.23), not major.minor.patch. The version 1.25.5 doesn't exist and will cause the module to fail validation. Use a valid Go version like 1.21 or 1.23.
Suggested change
| go 1.25.5 | |
| go 1.21 |
Fix it with Roo Code or mention @roomote and request a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 7 new opcodes to the Von Neumann VM:
New Opcodes
Bitwise Operations (all operate on int64)
Comparison Operations
Changes
von/cpu.goassembler/asm.goassembler/asm_test.gogo.modfor module supportTest Results
All 16 tests pass (11 new + 5 existing).