vmware_fs: remove funtionally-dead code, avoid ASSERT on unmount. #65
+16
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFile(). This was introduced in HaikuArchives#48, with a default value of `false`. But the methods were only ever called with it set to `true`. AFAICS, the buffer in question always comes from (and goes to) userspace, so the unconditional use of `user_memcpy()` in those methods seems to be the correct choice anyway. Also: removed a duplicated comment line (added on HaikuArchives#48 too).
Avoids the ASSERT on HaikuArchives#64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits:
vmware_fs: remove the "buffer_is_user" parameter from ReadFile()/WriteFile().
This was introduced in #48, with a default value of
false. But the methods were only ever called with it set totrue.AFAICS, the buffer in question always comes from (and goes to) userspace, so the unconditional use of
user_memcpy()in those methods seems to be the correct choice anyway.Also: removed a duplicated comment line (added on #48 too).
and:
vmware_fs: put root vnode on unmount.
Avoids the ASSERT on #64.