Skip to content

Conversation

@mademone
Copy link

No description provided.

Copy link
Contributor

@titaniumbones titaniumbones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael, see my comments , which are attached to line numbers in your PR.

"periods": ["ancient", "medieval", "early modern", "modern", "contemporary"],
"regions": ["Europe", "North America"],
"styles": ["political", "diplomatic", "cultural", "social", "art", "intellectual", "economic"],
"picture": "../images/your-image.jpg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to a URL:

  • either upload an image of yourself to the "dist/images" folder and change this value to reflect the precise name of your image
  • or, alternatively, point to the full URL of an existing image on the internet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have completed this.

"regions": ["Europe", "North America"],
"styles": ["political", "diplomatic", "cultural", "social", "art", "intellectual", "economic"],
"picture": "../images/your-image.jpg",
"blurb": "../markdown-files/your-markdown-file.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to reflect the actual name of hte markdown file you wrote -- which right now is ../markdown-files/"Michael . You should however rename this file to Michael.md if you are able to do so -- and if you can, then adjust this value accordingly.

@@ -0,0 +1,5 @@
#Research Interests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space between # and Research

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, as I mentioned, this file should be renamed "Michael.md"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have completed this.

@titaniumbones
Copy link
Contributor

I have no idea how to implement any of the changes you've requested.

I'm really just asking you to do things you've already done? You simply edit the files you have already edited. But we cna discuss in/after class.

@titaniumbones
Copy link
Contributor

Hi Michael,
You're incredibly close. 3 small corrections still:

  • in your json file, there is an invisible "non-breaking space" at the veyr beginning of the ifle -- I don't know how it would have gotten there, but perhaps through a copy-paste error. You nee to simply position your cursor in front of the {, and press pbackspace to get rid of it
  • your "image" URL has two errors:
    • it should start with "./" instead of "../"
    • fie names on the web are case-sensitive. The ifnal letters should be JPG, not jpg.
      And that should be all!

@mademone
Copy link
Author

Excellent. I will resolve these outstanding issues shortly. Thanks again, Matt.

Correcting mystery space.
Closing spaces.
Correcting image file extension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants