Mostly fixing tests and deployment documentation with a hint of containerization#31
Open
vincepower wants to merge 2 commits intoHackerYou:masterfrom
Open
Mostly fixing tests and deployment documentation with a hint of containerization#31vincepower wants to merge 2 commits intoHackerYou:masterfrom
vincepower wants to merge 2 commits intoHackerYou:masterfrom
Conversation
Open
Author
|
Tagging @brentc just so this has some visibility. |
Contributor
|
@colindamelio something for you to consider! @vincepower Sorry, this slipped through the cracks and I never had time to consider it. I'm no longer with Juno, so it's not my call any more. Looks like it has some potential though. |
Author
|
@brentc Cool, thanks. I just assumed you were based on your description that showed up (CTO of Juno) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of what has changed in this PR:
This is the cleaner version of this PR, I just had too many commits in my late attempt as I messed around with testing on CircleCI.