forked from decompals/ultralib
-
Notifications
You must be signed in to change notification settings - Fork 3
Skip processing unused controllers via mask #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
someone2639
wants to merge
14
commits into
HackerN64:main
Choose a base branch
from
farisawan-2000:mask
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thar0
reviewed
Feb 21, 2025
Thar0
reviewed
Feb 23, 2025
Thar0
reviewed
Feb 23, 2025
Thar0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides comment typo
Thar0
approved these changes
Feb 23, 2025
Thar0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature
Author
|
Requesting re-review since now gamecube controllers are involved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Console Testing Needed
Behavior must be verified on console
Extra Hardware Needed
Needs hardware verification with e.g. nonstandard/multiple controllers, mempaks, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From commit 08facd523e99661be99b61dc10b8f2b9516244ad in DKR