Skip to content

Conversation

@aglab2
Copy link
Collaborator

@aglab2 aglab2 commented Nov 30, 2025

Closes #911 for 3.0 branch. Still requires merge in from 2.4.x but intentionally omitted to avoid merge conflicts.

  • Fixed constness missing in print-like functions causing compilation issues with print_text(20, 20, "TEST") pattern.
  • Fixed incorrect function type for sTransitionUpdate.

Copy link
Collaborator

@gheskett gheskett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update basic_update() to not take an argument. Looks fine to me otherwise, assuming everything compiles as expected.

@aglab2
Copy link
Collaborator Author

aglab2 commented Nov 30, 2025

I would update basic_update() to not take an argument. Looks fine to me otherwise, assuming everything compiles as expected.

It already does not

void basic_update(void);

This was the main reason why compilation failed. Apparently C17 was fine with it.

Copy link
Collaborator

@gheskett gheskett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me when I accidentally cross compare the wrong repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants