-
Notifications
You must be signed in to change notification settings - Fork 192
Label Mario action returns #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
someone2639
wants to merge
7
commits into
HackerN64:develop/3.0.0
Choose a base branch
from
someone2639:mario_actions2
base: develop/3.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think this may be better suited for 3.0 |
Collaborator
Author
|
reset the base to 3.0 (now to rebase) |
# This is the 1st commit message: Update to newest UNF (d5f2ad100b76e372036453f8d25f9b6fbbbd2d1a) (November 22 2023) # This is the commit message HackerN64#2: Add option for .local/share/HackerSM64/UNFLoader-dir.txt This allows referencing a custom UNFLoader path to be used, ideally for placing on the C drive for WSL instances. UNFLoader tends to hang for an unbearably long time when saved somewhere within the WSL directory structure, and simply using the Linux build isn't an option because it can't access Windows USB devices trivially.
…mber 22 2023) Add option for .local/share/HackerSM64/UNFLoader-dir.txt This allows referencing a custom UNFLoader path to be used, ideally for placing on the C drive for WSL instances. UNFLoader tends to hang for an unbearably long time when saved somewhere within the WSL directory structure, and simply using the Linux build isn't an option because it can't access Windows USB devices trivially. Dialogs in dialogs.h no longer have to be in order (HackerN64#832) reset adjacent rooms when loading a new area (HackerN64#704) Check for opensuse's cross mips gcc package (HackerN64#842) Makes it possible to rely on the official repo. Ideally the following instructions would also be added to the wiki for opensuse: ``` sudo zypper install cross-mips-binutils git capstone pkgconf python311 cross-mips-gcc14 sudo zypper install --type pattern devel_basis ``` Support pre word-swapped textures, fix puppyprint rendering for lowercase z and tilde, minor font fixes (HackerN64#838) * Fix puppyprint rendering lowercase z and tilde, minor font fixes * Add support for generating pre word swapped textures * Use image for fasttext font texture * Adjustments to fasttext font and puppyprint outline font Place stack canaries behind DEBUG_ASSERTIONS instead of DEBUG (HackerN64#843) Add action continue/finish defines; mario.c labeled airborne actions labeled all actions labeled last labels i swear actual last one
978fbda to
810b4c6
Compare
Collaborator
Author
|
rebased and ready for review |
arthurtilly
reviewed
Jan 30, 2025
arthurtilly
approved these changes
Jan 30, 2025
gheskett
requested changes
Feb 16, 2025
gheskett
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
low priority
Non-urgent issue or feature / low priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign labels,
ACTION_CONTINUEandACTION_FINISHto replaceTRUEandFALSEin Mario's action functions, in order to explain their purpose better.