-
Notifications
You must be signed in to change notification settings - Fork 192
Split camera.c #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop/3.0.0
Are you sure you want to change the base?
Split camera.c #827
Conversation
|
I believe this PR is ready for initial review. As always, the README has the intended file structure in case there are comments on that. Things to consider:
|
|
i see a TODO in the PR description so either do it or update the description if its outdated... |
|
updated |
src/camera/README.md
Outdated
| @@ -0,0 +1,19 @@ | |||
| # Camera | |||
|
|
|||
| The camera system in SM64 is notoriously complex, with the original file exceeding 11000 lines of code. HackerSM64 separates the camera code into more relevant and granular files. An index of changes is provided below. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I feel about a readme in the middle of source files lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbf this is a big enough change to warrant one (at the very least to prevent some where camera issues from people who dont use the server)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to remove this; it's still in the history so I can put it into the wiki probably
|
|
||
| return cutscene; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is all this crap just moved here from camera.c?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed like a better place for it within the existing files than camera.c itself, though if a custom file can hold all this, then I can do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah thats fine, just was unclear


camera.c 11148 ->
31782441 linesSee README for details on file structure
TODO's for the PR:Decide on whether it's worth adding a file for camera shake and camera sound(Decided not worth by popular vote)