Brussels | itp-2025-1 | Tam Huynh | Onboarding | Coursework/form-controls branch #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now you have two duplicate pull requests. Either make sure this pull request only includes changes of the form controls task, or close the duplicate pull request |
noahg9
suggested changes
Dec 16, 2025
| this will also help you fill in your PR message later--> | ||
| <label for="name">What's your name?</label> | ||
| <br> | ||
| <input type="text" name="text" id="name" minlength="3" required placeholder="yourName"> |
There was a problem hiding this comment.
The name field should allow 2 or more characters, not 3 or more
| <br> | ||
| <input type="email" id="mail" name="mail" required placeholder="example@domain.com" pattern="^[^@\s]+@[^@\s]+\.[^@\s]+$"> | ||
|
|
||
| <p>What color do you like?</p> |
There was a problem hiding this comment.
The colour options should be grouped using semantic html. Wrap the radio buttons using fieldset and legend
|
|
||
| <label for="mail">What's your email?</label> | ||
| <br> | ||
| <input type="email" id="mail" name="mail" required placeholder="example@domain.com" pattern="^[^@\s]+@[^@\s]+\.[^@\s]+$"> |
There was a problem hiding this comment.
Make sure all related inputs are grouped together with fieldset and legend, i.e. name and email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.