Brussels | ITP-2025-1 | Pinky Benitez | Week-2 | Form controls

[Pinx-pinx]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

-My form is semantic html only.
-All inputs have associated labels.
-My Lighthouse Accessibility score is 100.
-I have defined a valid name
-I have required a valid email.
-I have required one colour from a defined set of 3 colours.
-I have required one size from a defined set of 6 sizes.

Questions

Ask any questions you have for your reviewer.

[talmurshidi]

Well done, @Pinx-pinx

What You Did Well

• Used semantic HTML with clear structure (<header>, <main>, <footer>).
• Added labels for all inputs — great for accessibility.
• Applied validation attributes: required, minlength, and pattern for the name field.
• Correctly used type="email" for email validation.
• Grouped inputs inside <fieldset> and added <legend> — perfect for screen readers.
• Limited colour and size choices using radio buttons — excellent approach.
• Followed the requirement of no CSS or JavaScript.

What Needs Improvement

• You added not related files to the branch, please DON"T use git add . . It's a recommendation for future.
• There is an extra closing </fieldset> tag before the size section — remove it to fix HTML structure.
• Add a submit button (<button type="submit">Submit</button>) so the form can be tested properly.
• Maintain consistent indentation — use two spaces for nested elements.
• Avoid <br> tags for spacing; instead, wrap inputs in <div> or <p> for better semantic structure.
• The pattern on the name field is advanced; consider keeping only minlength="2" for beginner clarity.

Example Correction

<!-- Remove this extra fieldset closing tag -->
</fieldset> <!--  Delete this one -->

<!-- Add a submit button at the end of the form -->
<button type="submit">Submit</button>

[Pinx-pinx]

Hello @talmurshidi I’ve made all the requested changes. Please review when you have time. Thank you!