Yana P.#6
Open
YanaP1312 wants to merge 4 commits intoHackYourAssignment:mainfrom
Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
Ro-P
approved these changes
Apr 12, 2026
Ro-P
left a comment
There was a problem hiding this comment.
Good job! All requirements are met.
Good thinking on adding the pull_request trigger, this means your CI will also run when someone opens a PR against main. But right now, even if the CI fails on a PR, someone can still merge it. The trigger alone doesn't block anything.
Small challenge: Make the CI actually enforce quality by adding a branch protection rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.