Mareh A.#5
Open
mareh-aboghanem wants to merge 1 commit intoHackYourAssignment:mainfrom
Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
| node-version: "20" | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci |
There was a problem hiding this comment.
Good use on using npm ci!
What are the benefits of using this instead of npm install here?
| export function SearchBar({ onSearch, loading }: Props) { | ||
| const [value, setValue] = useState(""); | ||
| const unusedConstMaybeDeleteMe = "Search"; | ||
| //const unusedConstMaybeDeleteMe = "Search"; |
There was a problem hiding this comment.
Since this a issue in code, and won't be use in future, doesn't bring value leaving this code commented. Comments usually are used to explain context. So you can remove this line
rafasilpereira
approved these changes
Apr 15, 2026
rafasilpereira
left a comment
rafasilpereira
left a comment
There was a problem hiding this comment.
Good job! 👏
Good that you left the pull request to see the results of your job!
How did you check it if this work properly? In your machine or direct in Github?
rafasilpereira
added
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.