Skip to content

Monerh A#3

Open
Miuroro wants to merge 2 commits intoHackYourAssignment:mainfrom
Miuroro:main
Open

Monerh A#3
Miuroro wants to merge 2 commits intoHackYourAssignment:mainfrom
Miuroro:main

Conversation

@Miuroro
Copy link
Copy Markdown

@Miuroro Miuroro commented Apr 8, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

@mvcatsifma mvcatsifma self-requested a review April 16, 2026 10:18
@mvcatsifma
Copy link
Copy Markdown

Good work — all requirements are met: lint, tests, build, and the artifact is explicitly zipped before uploading. The linter fix is clean and focused. Two well-described commits, one for each concern.

A couple of things to improve for next time:

Remove the "Start dev server" steptimeout 10 npm run dev || true has no place in a CI pipeline. The assignment doesn't require it, and the || true suppresses any errors. Only include steps that are part of the CI requirements.

Pin the Node.js versionnode-version: 'latest' means your workflow can break silently when a new major Node version is released. Use a specific version like '20' instead.

@mvcatsifma mvcatsifma added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants