Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/workflows/task-1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Integration

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
test:
runs-on: ubuntu-latest

defaults:
run:
working-directory: task-1

steps:
- name: Check out code
uses: actions/checkout@v6

- name: Set up Node.js
uses: actions/setup-node@v6
with:
node-version: "24"
cache: "npm"
cache-dependency-path: task-1/package-lock.json
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose to add this configuration?


- name: Install dependencies
run: npm ci
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of npm ci!

Do you know the difference between this and npm install?


- name: Run Linter
run: npm run lint

- name: Run Unit Tests
run: npm test

- name: Build React App
run: npm run build

- name: Upload Build Artifact
uses: actions/upload-artifact@v7
with:
name: weather-app-dist
path: task-1/dist/
retention-days: 5
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This is really good choice. Imagining that you have multiple PR merges and big teams, you should think about storage, because it has a cost and limit.

1 change: 0 additions & 1 deletion task-1/src/components/SearchBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ interface Props {

export function SearchBar({ onSearch, loading }: Props) {
const [value, setValue] = useState("");
const unusedConstMaybeDeleteMe = "Search";

const handleSubmit = (e: FormEvent) => {
e.preventDefault();
Expand Down