Atiqa N.#19
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js |
There was a problem hiding this comment.
Even the assignement is not mentioning it, it's a good practice of setting the node version. Curiosity: why 20?
| node-version: '20' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm install |
There was a problem hiding this comment.
For study purposes this works well, but I would recommend the reading of npm ci and how it deffers from npm install. When working in deployed a software it could have a difference
| ## Implementation Instructions | ||
| ### Task 1 | ||
| Add your gitHub action file in `.github/workflows/task-1.yaml` (Note: inside the existing .github folder found on the root of the repository) | ||
| Add your gitHub action file in `.github/workflows/task-1.yaml` (Note: inside the existing .github folder found on the root of the repository) No newline at end of file |
There was a problem hiding this comment.
The only change here is removing the trailing newline at the end of the file. This was probably done by your editor automatically. You can revert it by run:
git checkout main -- README.md
rafasilpereira
left a comment
rafasilpereira
left a comment
There was a problem hiding this comment.
Good work :claps:
I've run locally and the steps are working good!
Tips and Questions:
- You 6 commits with the same message. A commit message is such as a storyline of your work and it helps other developer to read throught your development process.
- How would you make this action run in the Pull Request?
- How did you test that this work?
rafasilpereira
added
Reviewed
|
|
||
| - name: Run unit tests | ||
| run: npm test | ||
| working-directory: ./task-1 |
There was a problem hiding this comment.
You can use defaults sections to define the working-directory for all steps and avoid duplication. Read this doc for more.
2 participants
No description provided.