You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good work — all requirements are met: lint, tests, build, the artifact is explicitly zipped before uploading, and the linter fix is correct. The pipeline ran and passed.
A few things to improve for next time:
Wrong filename — the README specifies .github/workflows/task-1.yaml, but the file is named weather-app.yml. Follow the naming convention given in the instructions.
Commit hygiene — 6 commits for this task is too many. Aim for one commit per concern: one for the CI pipeline, one for the linter fix.
Unnecessary style changes in SearchBar.tsx — the only linter error was the unused variable. The quote normalization changes throughout the file were not required and unrelated to the task. Keep changes focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReviewedThis assignment has been reivewed by a mentor and a feedback has been provided
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.