Dagim H.#16
Open
Unlock7 wants to merge 1 commit intoHackYourAssignment:mainfrom
Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
|
Good work — all requirements are met: the CI pipeline runs lint, tests, and build in the correct order, the linter error is fixed, and the build artifact is uploaded. A couple of improvements for next time: Commit hygiene — this should be split into two commits: one for the CI pipeline, one for the linter fix. Separate concerns make the history easier to follow. Unnecessary changes in SearchBar.tsx — aside from removing the unused variable, there are additional style changes (quotes, arrow function formatting). These weren’t required. Keep changes focused on what the task asks. |
mvcatsifma
added
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix linter error and setup CI pipeline!