Diana#13
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Goog thing on leaving this in the PR level. As you can see in the PR, I ran it and it run succesfully. But it was the first time that it run. How did you test your developments?
| node-version: "24" # Can also use 'latest' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm install # npm clean install |
There was a problem hiding this comment.
I see that one of your commits you changed from npm ci to npm install. What made you make this change? I recommend read npm ci docs
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ./task-1 |
There was a problem hiding this comment.
Good use on default folder! This avoid duplication of text in other steps!
rafasilpereira
left a comment
rafasilpereira
left a comment
There was a problem hiding this comment.
Very good job! :claps:
Very clear commit messages, which helps a lot in analyzing the PR.
And the Steps were very clear and clean and run succesfully.
Any doubts on my comments let me know!
rafasilpereira
added
Reviewed
2 participants
No description provided.