Skip to content

Monerh A#6

Open
Miuroro wants to merge 3 commits into
HackYourAssignment:mainfrom
Miuroro:main
Open

Monerh A#6
Miuroro wants to merge 3 commits into
HackYourAssignment:mainfrom
Miuroro:main

Conversation

@Miuroro
Copy link
Copy Markdown

@Miuroro Miuroro commented Apr 1, 2026

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mvcatsifma
Copy link
Copy Markdown

Taking this review @Miuroro

@mvcatsifma
Copy link
Copy Markdown

mvcatsifma commented Apr 7, 2026

@Miuroro

Solid work — the implementation is largely correct and the output is almost identical to the reference.

A few points to improve:

Output verification
The README asks you to compare actual vs expected output. You’re one line off: learned returns 1 instead of true because the raw SQLite value isn’t converted. A quick diff would have caught this immediately.

Commit messages
"finished implementing files for the flashcard app task-2" describes your process, not the change. Prefer messages like:
Implement SQLite storage layer in database.js

Tests
There are no tests. Without them, correctness depends on manually running the app and checking output. Even a few simple assertions would catch issues like this and prevent regressions.

Error handling
The try/catch blocks in database.js catch real errors and rethrow them as "Not implemented", which hides the actual failure. Let errors propagate so they remain debuggable.

cc @stasel

@Miuroro
Copy link
Copy Markdown
Author

Miuroro commented Apr 7, 2026

thank you for the feedback ill check my code again and make the necessary changes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

@mvcatsifma mvcatsifma self-requested a review April 9, 2026 09:34
@mvcatsifma mvcatsifma added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants