-
Notifications
You must be signed in to change notification settings - Fork 19
Shadi.A #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Shadi.A #9
Conversation
📝 HackYourFuture auto gradeAssignment Score: 85 / 100 ✅Status: ✅ Passed Test Details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shmoonwalker, nice work overall, you show a good understanding of the first week’s topics 👍
I left some feedback comments about small details (exact file names, messages, and Git usage). Paying attention to these details is a good practice.
About the second task: nice GitHub welcome page, it looks good! The top languages card is missing data, it would be nice to fix this.
Overall, you did a good job. Good luck on your journey at Hack Your Future.
| touch program.java | ||
| cd .. | ||
| git add . | ||
| git commit -a -m "initial commit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sinc you already used git add ., so git commit -a is not needed here. Using git commit -m "initial commit" is clearer.
| git add . | ||
| git commit -a -m "initial commit" | ||
| sleep 3 | ||
| echo "Setup project" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the first comment about details, the assignment asks for the exact message Setup project…. It’s good practice to match the wording and casing exactly.
| cd ../resources | ||
| rm family_picture.jpg | ||
| cd .. | ||
| git commit -a -m "write welcome text to README, remove profile directory , remove family_picture.jpg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and descriptive commit message 👍
Small note: It’s usually clearer and safer to run git add . and then commit using git commit -m, instead of using git commit -a -m.
| sleep 3 | ||
| cd resources | ||
| ls -la | ||
| echo "Setup javascript" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording and details: Setup javascript…
Assignment for week one is completed