-
Notifications
You must be signed in to change notification settings - Fork 19
Initialize project structure and setup JavaScript #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Set up project structure, initialize git, and create initial files including README and resources. Removed unnecessary files and set up a JavaScript program.
📝 HackYourFuture auto gradeAssignment Score: 22 / 100 ❌Status: ❌ Not passed Test Details |
remarcmij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @homsi6313-art, although task1 seems to work on my computer, you added some statements that were not part of the assignment and that may have cause the autograding to fail.
The task2 seems to be unfinished. This needs more work.
| @@ -1 +1,63 @@ | |||
| # Write your code here | |||
| #!/bin/bash | |||
| set -e | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not asked for in the instructions.
| SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" | ||
| cd "$SCRIPT_DIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
| SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" | ||
| cd "$SCRIPT_DIR" | ||
|
|
||
| mkdir -p project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -p option is superfluous here and elsewhere where you used mkdir. There are no intermediate directories to create. Mind the YAGNI principle:
a programmer should not add functionality until deemed necessary.
| sleep 3 | ||
| echo "Setup project..." | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single blank line to separate blocks of code is customary.
Set up project structure, initialize git, and create initial files including README and resources. Removed unnecessary files and set up a JavaScript program.