-
Notifications
You must be signed in to change notification settings - Fork 19
Mohamad Bader AA #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 HackYourFuture auto gradeAssignment Score: 58 / 100 ✅Status: ✅ Passed Test Details |
mnvacym
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mohamad, great job on your first assignment.
There are minor improvements needed for the first task. I’ve added comments with suggestions; please let me know if anything is unclear.
For the second task, it looks like there is an issue with Top Languages Card on your GitHub profile.
Overall, you did a good job. Best of luck on your journey at Hack Your Future.
| @@ -1 +1,34 @@ | |||
| # Write your code here | |||
| echo "Creating project…" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually it is a good practice to include #!/bin/bash or #!/usr/bin/env bash line at the beginning of a shell script file.
| @@ -1 +1,34 @@ | |||
| # Write your code here | |||
| echo "Creating project…" | |||
| mkdir project; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In shell scripting, using semicolons ath the end of a line is not necessary, but it is possible to use them of course.
| git commit -m "initial commit" | ||
| sleep 3 | ||
| echo "Setup projet..." | ||
| echo "Welcome to my project" >README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of this point you're still in src directory. So README.md file will be created in src, but it needs to be in the root (project) directory.
| cd ../resources | ||
| rm "family picture.jpg" | ||
| git add -A | ||
| git commit -m "second commit" -m "removed family picture Woopsie😁 and my personal profile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on a descriptive commit message. But a signle message needs to be created. You can remove the first one.
| echo 'console.log("JavaScript Works!");' >program.js | ||
| node program.js | ||
| git add -A | ||
| git commit -m "third commit" -m "java script works now/ renamed program and added 1 line of code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on a descriptive commit message. But a signle message needs to be created. You can remove the first one.
| sleep 3 | ||
| echo "Setup projet..." | ||
| echo "Welcome to my project" >README.md | ||
| cd src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are already in src directory, this command will throw an error:
line 17: cd: src: No such file or directory
| mkdir database profile | ||
| touch program.java | ||
| git add -A | ||
| git commit -m "initial commit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of this point you're still in src directory. It's usually a good practice to change directory into the root before running git commands.
No description provided.