Shadi A.#8
Open
shmoonwalker wants to merge 4 commits into
Open
Conversation
…and readability. Updated grade handling to use dynamic module count, enhanced input validation, and improved user feedback messages. Adjusted formatting in output displays for better clarity.
Feature/impelemnt task 1
mvcatsifma
reviewed
May 20, 2026
mvcatsifma
left a comment
There was a problem hiding this comment.
Clean and well-structured submission with good input validation and some nice defensive coding touches, especially readIntInRange(), getModuleName() bounds checking, and returning grades.clone() for encapsulation.
Main improvement areas:
- The project currently does not run due to the package/setup issue (
Main.javamissingpackage com.hyfacademy;combined with the flat directory structure). Always run and test the application before submitting. - The average calculation currently includes ungraded modules (
0values), which unfairly lowers the student average. - Public methods are missing Javadoc comments.
- Formatting and indentation are inconsistent in several places.
For future assignments:
- Always compile and run the project before submission.
- Validate calculation logic against edge cases like partially graded students.
- Add Javadoc for public methods and utility classes.
- Use an auto-formatter to keep formatting consistent.
Good overall effort and solid Week 1 progress.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Complete Task 1