Skip to content

Shadi A.#8

Open
shmoonwalker wants to merge 4 commits into
HackYourAssignment:mainfrom
shmoonwalker:main
Open

Shadi A.#8
shmoonwalker wants to merge 4 commits into
HackYourAssignment:mainfrom
shmoonwalker:main

Conversation

@shmoonwalker
Copy link
Copy Markdown

Complete Task 1

shmoonwalker and others added 3 commits May 6, 2026 20:23
…and readability. Updated grade handling to use dynamic module count, enhanced input validation, and improved user feedback messages. Adjusted formatting in output displays for better clarity.
Copy link
Copy Markdown

@mvcatsifma mvcatsifma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and well-structured submission with good input validation and some nice defensive coding touches, especially readIntInRange(), getModuleName() bounds checking, and returning grades.clone() for encapsulation.

Main improvement areas:

  • The project currently does not run due to the package/setup issue (Main.java missing package com.hyfacademy; combined with the flat directory structure). Always run and test the application before submitting.
  • The average calculation currently includes ungraded modules (0 values), which unfairly lowers the student average.
  • Public methods are missing Javadoc comments.
  • Formatting and indentation are inconsistent in several places.

For future assignments:

  • Always compile and run the project before submission.
  • Validate calculation logic against edge cases like partially graded students.
  • Add Javadoc for public methods and utility classes.
  • Use an auto-formatter to keep formatting consistent.

Good overall effort and solid Week 1 progress.

@mvcatsifma mvcatsifma added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels May 20, 2026
@shmoonwalker
Copy link
Copy Markdown
Author

Clean and well-structured submission with good input validation and some nice defensive coding touches, especially readIntInRange(), getModuleName() bounds checking, and returning grades.clone() for encapsulation.

Main improvement areas:

  • The project currently does not run due to the package/setup issue (Main.java missing package com.hyfacademy; combined with the flat directory structure). Always run and test the application before submitting.
  • The average calculation currently includes ungraded modules (0 values), which unfairly lowers the student average.
  • Public methods are missing Javadoc comments.
  • Formatting and indentation are inconsistent in several places.

For future assignments:

  • Always compile and run the project before submission.
  • Validate calculation logic against edge cases like partially graded students.
  • Add Javadoc for public methods and utility classes.
  • Use an auto-formatter to keep formatting consistent.

Good overall effort and solid Week 1 progress.

Hey Thomas. thank you for reviewing my code. i used vim in first two week for codes thats why its not well formatted .also no idea what is Javadoc but i will try to write comments for my functions from now on. also i run the project again and for me its working
i made change in calculateAverage method as well.
thanks a lot
Screenshot 2026-05-20 at 18 10 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants