Skip to content

Salem Ba-Rabuod#7

Open
Barboud wants to merge 12 commits into
HackYourAssignment:mainfrom
Barboud:main
Open

Salem Ba-Rabuod#7
Barboud wants to merge 12 commits into
HackYourAssignment:mainfrom
Barboud:main

Conversation

@Barboud
Copy link
Copy Markdown

@Barboud Barboud commented May 7, 2026

No description provided.

@selimcandalgic
Copy link
Copy Markdown

Nice start with the first assignment Salem. Couple of remarks :

  1. Input parsing when student name and id is fragile and can be broken.
  2. seedData needs to be removed.
  3. MODULE_COUNT constant can be used in Student.grades array
  4. Student.grades is initialised twice - constructor and field
  5. Student.toString() method is missing @Override annotation.
  6. setGrades boundary check doesn't check for negative numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants