Skip to content

Monerh A#6

Open
Miuroro wants to merge 4 commits into
HackYourAssignment:mainfrom
Miuroro:main
Open

Monerh A#6
Miuroro wants to merge 4 commits into
HackYourAssignment:mainfrom
Miuroro:main

Conversation

@Miuroro
Copy link
Copy Markdown

@Miuroro Miuroro commented May 7, 2026

No description provided.

Copy link
Copy Markdown

@mvcatsifma mvcatsifma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid submission. The code structure is clean, the logic is organized clearly, and the required menu functionality appears to be implemented.

Main improvement areas:

  • The project currently does not run due to a package/dependency issue partly related to the starter setup.
  • Invalid grade values such as 150 or -5 are rejected by setGrade(), but the input loop still continues to the next module instead of asking the user to retry the input.
  • The average calculation currently includes ungraded modules (0 values), which can unfairly lower the student’s average score.
  • Public methods are missing Javadoc comments.

For future assignments:

  • Always run and test the application before submission.
  • Strengthen validation logic around user input.
  • Add Javadoc for public methods and utility classes.

Good overall effort and solid progress for Week 1.

@mvcatsifma mvcatsifma added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants