Skip to content

R. Yusup#5

Open
Yusuprozimemet wants to merge 1 commit into
HackYourAssignment:mainfrom
Yusuprozimemet:main
Open

R. Yusup#5
Yusuprozimemet wants to merge 1 commit into
HackYourAssignment:mainfrom
Yusuprozimemet:main

Conversation

@Yusuprozimemet
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mvcatsifma mvcatsifma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid and readable submission with correct grade retry logic and working menu paths.

Main improvement areas:

  • The project currently does not run due to the package/setup issue, even though Main.java correctly includes package com.hyfacademy;. Always compile and run the full application before submitting.
  • The average calculation currently includes ungraded modules (0 values), which unfairly lowers student averages.
  • The FAIL status output is missing the symbol (FAIL vs ✗ FAIL).
  • Student lookup is case-sensitive (equals() instead of equalsIgnoreCase()), making IDs less user-friendly.
  • Public methods are missing Javadoc comments.
  • Commit message ("ready") does not describe the implemented changes.

For future assignments:

  • Always run and test all menu flows before submission.
  • Validate calculation logic against edge cases like partially graded students.
  • Use descriptive commit messages that explain what was implemented.
  • Add Javadoc for public methods and utility classes.

Good overall effort and solid Week 1 progress.

@mvcatsifma mvcatsifma added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants