R. Yusup#5
Open
Yusuprozimemet wants to merge 1 commit into
Open
Conversation
mvcatsifma
reviewed
May 20, 2026
mvcatsifma
left a comment
There was a problem hiding this comment.
Solid and readable submission with correct grade retry logic and working menu paths.
Main improvement areas:
- The project currently does not run due to the package/setup issue, even though
Main.javacorrectly includespackage com.hyfacademy;. Always compile and run the full application before submitting. - The average calculation currently includes ungraded modules (
0values), which unfairly lowers student averages. - The FAIL status output is missing the
✗symbol (FAILvs✗ FAIL). - Student lookup is case-sensitive (
equals()instead ofequalsIgnoreCase()), making IDs less user-friendly. - Public methods are missing Javadoc comments.
- Commit message (
"ready") does not describe the implemented changes.
For future assignments:
- Always run and test all menu flows before submission.
- Validate calculation logic against edge cases like partially graded students.
- Use descriptive commit messages that explain what was implemented.
- Add Javadoc for public methods and utility classes.
Good overall effort and solid Week 1 progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.