Conversation
Owner
Author
|
In principle most of the things we would like to see from class should be present. I tried generating a few (O(10^3) samples) minimal NNs to check that the behaviour is correct, and I think it matches most of the CAMB interface now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress for a CLASS interface. Will merge this when it is close enough to parity with the CAMB interface.
Thanks to Alex Nemtinova for initiating this and aiding me in fixing bugs relating to my ignorance when it comes to CLASS.
To match CAMB parity, we will need auto-generation of:
On top of that, it might be nice to:
The automatic setting inference is currently done via the "auto: True" flag in the extra_args block in the yaml. It's probably better to have everything done by the end user however, as class has too many accuracy settings that could realistically be inferred by the code (at least for camb, the only real parameter that has to be inferred is the redshift grid for quantities that vary with redshift, like sigma8(z)). It might be easier to parse the parameters and halt if there's an inconsistency (like lmax_calculated < lmax_requested), rather than try to parse the requested parameters and modifying the settings accordingly...
All work should be limited to writing the
spectra_classy.pyfile, as the remaining interfacing is handled automatically by the pipeline from there.