Skip to content

Improvements in line page icons#1436

Merged
suvikankare merged 3 commits into
mainfrom
line-icon
May 29, 2026
Merged

Improvements in line page icons#1436
suvikankare merged 3 commits into
mainfrom
line-icon

Conversation

@suvikankare
Copy link
Copy Markdown
Member

@suvikankare suvikankare commented May 29, 2026

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@suvikankare suvikankare marked this pull request as ready for review May 29, 2026 07:51
Copy link
Copy Markdown
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huulivoide reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on suvikankare).


ui/src/components/routes-and-lines/line-details/LineDetailsByIdPage.tsx line 55 at r1 (raw file):

      );
    default:
      return null;

Meillä on kuitenkin ne muutkin ikonit olemassa ja värit tiedossa, niin ne vois saman tien nakata tänne sisään, niin ei tarvi sitten uudelleen joskus tulevassa tänne palata tai ottaa sitä vaaraa että tulee joku bugi tiketti ku sieltä kuitenkin saa valita sen metron tai laitan jo nyt, mutta sitten ei ikoni näykkään.

Copy link
Copy Markdown
Member Author

@suvikankare suvikankare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suvikankare made 1 comment.
Reviewable status: 4 of 20 files reviewed, 1 unresolved discussion (waiting on Huulivoide).


ui/src/components/routes-and-lines/line-details/LineDetailsByIdPage.tsx line 55 at r1 (raw file):

Previously, Huulivoide (Jesse Jaara) wrote…

Meillä on kuitenkin ne muutkin ikonit olemassa ja värit tiedossa, niin ne vois saman tien nakata tänne sisään, niin ei tarvi sitten uudelleen joskus tulevassa tänne palata tai ottaa sitä vaaraa että tulee joku bugi tiketti ku sieltä kuitenkin saa valita sen metron tai laitan jo nyt, mutta sitten ei ikoni näykkään.

Done.

Copy link
Copy Markdown
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huulivoide reviewed 16 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on suvikankare).

@suvikankare suvikankare merged commit 08666e1 into main May 29, 2026
24 checks passed
@suvikankare suvikankare deleted the line-icon branch May 29, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants