feat: add required Project combobox on agreement details edit#5197
Merged
feat: add required Project combobox on agreement details edit#5197
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a required Project combobox to the non-wizard Agreement Details edit form, sourcing options from /projects while keeping the wizard flow unchanged.
Changes:
- Introduces/updates
ProjectComboBoxto display options asTitle (Short Title)and support required hint/error rendering. - Wires project fetching/selection/validation into the non-wizard
AgreementEditForm+ disables Save whenproject_idis missing. - Expands unit + Cypress coverage for wizard-vs-details rendering and required/disabled behaviors.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/pages/agreements/details/AgreementDetailsEdit.test.js |
Updates API mocks to include projects query and richer loading/error shape. |
frontend/src/components/Projects/ProjectComboBox/ProjectComboBox.test.js |
Extends tests for Title (Short Title) labels and required/error messaging. |
frontend/src/components/Projects/ProjectComboBox/ProjectComboBox.jsx |
Adds label customization, required hint/error UI, and option label formatting using short_title. |
frontend/src/components/Agreements/AgreementEditor/AgreementEditFormSuite.js |
Adds project_id validation rule. |
frontend/src/components/Agreements/AgreementEditor/AgreementEditForm.project.test.jsx |
New tests for non-wizard-only rendering and disabled Save behavior. |
frontend/src/components/Agreements/AgreementEditor/AgreementEditForm.jsx |
Renders ProjectComboBox under nickname in non-wizard mode; loading includes projects. |
frontend/src/components/Agreements/AgreementEditor/AgreementEditForm.hooks.js |
Fetches projects, adds selection handler, validates/blocks Save when project is missing. |
frontend/cypress/e2e/editAgreement.cy.js |
Confirms project combobox is not shown in wizard flow. |
frontend/cypress/e2e/agreementDetailsEdit.cy.js |
Confirms project label exists in details edit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
josbell
approved these changes
Mar 4, 2026
josbell
approved these changes
Mar 4, 2026
johndeange
approved these changes
Mar 5, 2026
Contributor
|
🎉 This PR is included in version 1.316.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Title (Short Title)option labelsScreenshots
Automated Testing
cd frontend && bun run formatcd frontend && bun run lintcd frontend && bun run test --watch=false src/components/Projects/ProjectComboBox/ProjectComboBox.test.js src/components/Agreements/AgreementEditor/AgreementEditForm.project.test.jsx src/pages/agreements/details/AgreementDetailsEdit.test.jscd frontend && bun run test:coverage src/components/Projects/ProjectComboBox/ProjectComboBox.test.js src/components/Agreements/AgreementEditor/AgreementEditForm.project.test.jsx src/pages/agreements/details/AgreementDetailsEdit.test.jsManual Tests
Notes