to_work #441
to_work #441
Conversation
for more information, see https://pre-commit.ci
Codecov ReportBase: 47.20% // Head: 47.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 47.20% 47.65% +0.44%
==========================================
Files 54 54
Lines 2896 2894 -2
Branches 523 522 -1
==========================================
+ Hits 1367 1379 +12
+ Misses 1428 1409 -19
- Partials 101 106 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
vitodb
left a comment
vitodb
left a comment
There was a problem hiding this comment.
@biozit Fabio, thank you for testing DE on OSG and for the PR.
Some of the changes in this PR were addressed by other PR and one can be superseded by changes in configuration.
While the change in glideinwms is something that needs to be addressed.
| # _SUPPORTED_ENTRY_TYPES = ["LCF", "AWS", "Grid", "GCE"] | ||
| _SUPPORTED_ENTRY_TYPES = ["Grid"] | ||
|
|
||
| METRICS = { | ||
| "NUMBER_OF_JOBS": Gauge("de_jobs_total", "Number of jobs seen by the Decision Engine"), |
| entries = pandas.DataFrame( | ||
| pandas.concat([factory_entries.xs(et) for et in _SUPPORTED_ENTRY_TYPES], ignore_index=True, sort=True) | ||
| ) |
| entries = pandas.DataFrame([]) | ||
| if "Grid" in self.Factory_Entries(datablock).index: | ||
| entries = self.Factory_Entries(datablock).xs("Grid") | ||
| entries = self.Factory_Entries(datablock).xs("Grid") |
| # self.max_retries = config.get("max_retries") | ||
| self.max_retries = 10 | ||
| # self.retry_interval = config.get("retry_interval") | ||
| self.retry_interval = 1 |
There was a problem hiding this comment.
These changes are better addressed with changes in the configurations.
Current config_template have been updated to address this
| self.default_glidein_params = { | ||
| # TODO: Remove this classad once token/proxy hybrid configurations are no longer supported | ||
| "CONTINUE_IF_NO_PROXY": "False" | ||
| "CONTINUE_IF_NO_PROXY": "True" |
There was a problem hiding this comment.
Checking with @mambelli, this change would require a full token setup, while the current one works with an hybrid X509 cert/token setup. We could end up to have two versions of DE depending on the specific setup.
2 participants
No description provided.