Skip to content

Autotools fixes#210

Open
ajelenak wants to merge 32 commits intomasterfrom
autotools-fixes
Open

Autotools fixes#210
ajelenak wants to merge 32 commits intomasterfrom
autotools-fixes

Conversation

@ajelenak
Copy link
Copy Markdown
Contributor

@ajelenak ajelenak commented Dec 8, 2025

This is PR #202 without the changes in the LZ4 plugin because those changed the plugin's cd_values[].


Important

Update autotools configurations, plugin paths, and add test scripts for BZIP2, JPEG, LZ4, and LZF plugins.

  • Autoconf Updates:
    • Update AC_PREREQ to 2.71 in BZIP2/configure.ac, JPEG/configure.ac, LZ4/configure.ac, and LZF/configure.ac.
    • Change AC_INIT and AC_CONFIG_HEADERS syntax in BZIP2/configure.ac, JPEG/configure.ac, LZ4/configure.ac, and LZF/configure.ac.
  • Plugin Path Changes:
    • Rename HDF5_PLUGIN_DIR to HDF5_PLUGIN_PATH in BZIP2/configure.ac, JPEG/configure.ac, LZ4/configure.ac, and LZF/configure.ac.
    • Update plugindir to @HDF5_PLUGIN_PATH@ in BZIP2/src/Makefile.am, JPEG/src/Makefile.am, LZ4/src/Makefile.am, and LZF/src/Makefile.am.
  • Testing and Examples:
    • Add run_tests.sh to JPEG/example/Makefile.am, LZ4/example/Makefile.am, and LZF/example/Makefile.am.
    • Modify check_PROGRAMS and TESTS in JPEG/example/Makefile.am, LZ4/example/Makefile.am, and LZF/example/Makefile.am to include test scripts.
  • Miscellaneous:
    • Update libtool.m4 and ltversion.m4 in BZIP2/m4 to newer versions.
    • Adjust JPEG_QUALITY to 50 in JPEG/example/h5ex_d_jpeg.c and update related test files.

This description was created by Ellipsis for da1fab3. You can customize this summary. It will automatically update as commits are pushed.

Comment thread JPEG/example/h5ex_d_jpeg.c Outdated
Comment thread JPEG/src/H5Zjpeg.c Outdated
Comment thread Makefile.am Outdated
Comment thread BZIP2/m4/libtool.m4 Outdated
Comment thread configure.ac Outdated
@ajelenak ajelenak mentioned this pull request Dec 9, 2025
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@mattjala mattjala marked this pull request as draft December 9, 2025 17:29
@ellipsis-dev
Copy link
Copy Markdown

ellipsis-dev bot commented Jan 24, 2026

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at help@ellipsis.dev


Generated with ❤️ by ellipsis.dev

@ajelenak ajelenak marked this pull request as ready for review January 24, 2026 03:30
@ellipsis-dev
Copy link
Copy Markdown

ellipsis-dev bot commented Jan 24, 2026

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at help@ellipsis.dev


Generated with ❤️ by ellipsis.dev

@brtnfld
Copy link
Copy Markdown
Contributor

brtnfld commented Apr 18, 2026

stale comment in LZ4/configure.ac:
The AC_ARG_WITH help string still says "use it as a place for the large (i.e. > 2 GiB) files created during the large file testing", which was copy-pasted from HDF5 and is wrong for a plugin directory. In LZF this comment was correctly removed; it should be removed in LZ4 as well.

Issue — misleading AC_MSG_NOTICE in LZF/configure.ac:
Line AC_MSG_NOTICE([*** This is a configure for LZ4 ***]) is a pre-existing copy-paste bug but it's still in this PR unchanged. Should be fixed to say LZF.

Issue:
BZIP2/example/Makefile.am, LZ4/example/Makefile.am, and LZF/example/Makefile.am all reference run_tests.sh in both TESTS and EXTRA_DIST, but no run_tests.sh this file does not exist for BZIP2, LZ4, or LZF.

Issue: JPEG/src/H5Zjpeg.c removed jpegInfo.err assignment:

  •   jpegInfo.err = jpeg_std_error(&jpegErr);
    
  •   /* Now we can initialize the JPEG compression object. */
      jpeg_create_compress(&jpegInfo);
    

The line jpegInfo.err = jpeg_std_error(&jpegErr) was removed from the compression path immediately before jpeg_create_compress(), which violates the libjpeg API contract.

ALSO,
debug artifacts left in source:
The #ifdef JPEG_DEBUG / fprintf(stderr, ...) / #endif blocks (which were clean, conditional debug code) were replaced with commented-out printf("**** ...") calls:

  •    /* printf("****   decompressing nbytes: %ld\n", nbytes); */
    
  •        /* printf("****   jpegInfo.output_scanline: %d\n", jpegInfo.output_scanline);	     */
    
  •    /* printf("****    compressing nbytes: %ld cd_nelmts %ld\n", nbytes, cd_nelmts); */
    

These are development leftovers and should be removed entirely before merging. The original #ifdef JPEG_DEBUG pattern was better — it allowed debug output without code churn.

Issue:
LZF/example/h5ex_d_lzf.c:

  • printf(" Number of parameters is %d with the value %u\n", nelmts, values_out[0]);
  • printf(" Number of parameters is %ld with the value %u\n", nelmts, values_out[0]);
    %ld is still wrong for size_t — it should also be %zu, consistent with the JPEG fix. %ld works on most LP64 systems (Linux/macOS 64-bit) but is undefined behavior and fails on LLP64 (Windows 64-bit).

Copy link
Copy Markdown
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants