Conversation
The proposed changes need more discussion.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
Generated with ❤️ by ellipsis.dev |
|
Generated with ❤️ by ellipsis.dev |
|
stale comment in LZ4/configure.ac: Issue — misleading AC_MSG_NOTICE in LZF/configure.ac: Issue: Issue: JPEG/src/H5Zjpeg.c removed jpegInfo.err assignment:
The line jpegInfo.err = jpeg_std_error(&jpegErr) was removed from the compression path immediately before jpeg_create_compress(), which violates the libjpeg API contract. ALSO,
These are development leftovers and should be removed entirely before merging. The original #ifdef JPEG_DEBUG pattern was better — it allowed debug output without code churn. Issue:
|
This is PR #202 without the changes in the LZ4 plugin because those changed the plugin's
cd_values[].Important
Update autotools configurations, plugin paths, and add test scripts for BZIP2, JPEG, LZ4, and LZF plugins.
AC_PREREQto 2.71 inBZIP2/configure.ac,JPEG/configure.ac,LZ4/configure.ac, andLZF/configure.ac.AC_INITandAC_CONFIG_HEADERSsyntax inBZIP2/configure.ac,JPEG/configure.ac,LZ4/configure.ac, andLZF/configure.ac.HDF5_PLUGIN_DIRtoHDF5_PLUGIN_PATHinBZIP2/configure.ac,JPEG/configure.ac,LZ4/configure.ac, andLZF/configure.ac.plugindirto@HDF5_PLUGIN_PATH@inBZIP2/src/Makefile.am,JPEG/src/Makefile.am,LZ4/src/Makefile.am, andLZF/src/Makefile.am.run_tests.shtoJPEG/example/Makefile.am,LZ4/example/Makefile.am, andLZF/example/Makefile.am.check_PROGRAMSandTESTSinJPEG/example/Makefile.am,LZ4/example/Makefile.am, andLZF/example/Makefile.amto include test scripts.libtool.m4andltversion.m4inBZIP2/m4to newer versions.JPEG_QUALITYto 50 inJPEG/example/h5ex_d_jpeg.cand update related test files.This description was created by
for da1fab3. You can customize this summary. It will automatically update as commits are pushed.