Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/fixture_kit/coders/active_record_coder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,22 +60,28 @@ def base_table_model(model)

def generate_statements(models)
models.each_with_object({}) do |model, statements|
columns = model.column_names
columns = insertable_columns(model)
column_names = columns.map(&:name)

rows = []
model.unscoped.order(:id).find_each do |record|
row_values = columns.map do |col|
row_values = column_names.map do |col|
value = record.read_attribute_before_type_cast(col)
model.connection.quote(value)
end
rows << "(#{row_values.join(", ")})"
end

sql = rows.empty? ? nil : build_insert_sql(model.table_name, columns, rows, model.connection)
sql = rows.empty? ? nil : build_insert_sql(model.table_name, column_names, rows, model.connection)
statements[model] = sql
end
end

def insertable_columns(model)
supports_virtual = model.connection.supports_virtual_columns?
model.columns.reject { |c| supports_virtual && c.virtual? }
end

def build_delete_sql(connection, table_name)
"DELETE FROM #{connection.quote_table_name(table_name)}"
end
Expand Down
4 changes: 4 additions & 0 deletions spec/dummy/app/models/computed_widget.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# frozen_string_literal: true

class ComputedWidget < ApplicationRecord
end
21 changes: 21 additions & 0 deletions spec/integration/virtual_columns_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# frozen_string_literal: true

require "spec_helper"

# Models with generated/virtual columns can't accept INSERTs into those
# columns. The coder must filter them out when building cached statements.
RSpec.describe "Fixture round-trip with virtual columns" do
fixture do
ComputedWidget.create!(name: "alpha", quantity: 1)
ComputedWidget.create!(name: "beta", quantity: 2)
end

after { ComputedWidget.delete_all }

it "loads records with their generated column values" do
widgets = ComputedWidget.order(:id).to_a

expect(widgets.map(&:name)).to eq(["alpha", "beta"])
expect(widgets.map(&:name_upper)).to eq(["ALPHA", "BETA"])
end
end
8 changes: 8 additions & 0 deletions spec/support/dummy_rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def setup_databases
ActiveRecord::Base.connection.drop_table(:users, if_exists: true)
ActiveRecord::Base.connection.drop_table(:vehicles, if_exists: true)
ActiveRecord::Base.connection.drop_table(:gadgets, if_exists: true)
ActiveRecord::Base.connection.drop_table(:computed_widgets, if_exists: true)
end

AnalyticsRecord.connection.disable_referential_integrity do
Expand Down Expand Up @@ -88,6 +89,13 @@ def setup_databases
t.timestamps
end

ActiveRecord::Base.connection.create_table :computed_widgets, force: true do |t|
t.string :name, null: false
t.integer :quantity, null: false, default: 0
t.virtual :name_upper, type: :string, as: "UPPER(name)", stored: true
t.timestamps
end

# Analytics database schema
AnalyticsRecord.connection.create_table :activity_logs, force: true do |t|
t.integer :external_user_id, null: false
Expand Down
Loading