feat(SDK-545): add DetailViewLayout reusable component#1402
Open
krisxcrash wants to merge 1 commit intokw/feat/sdk-547from
Open
feat(SDK-545): add DetailViewLayout reusable component#1402krisxcrash wants to merge 1 commit intokw/feat/sdk-547from
krisxcrash wants to merge 1 commit intokw/feat/sdk-547from
Conversation
Shared shell for detail views providing back navigation, page header with title/subtitle/actions, and tabbed content layout. Used by all TimeOff policy detail view variants (PTO/Sick, Holiday, Unlimited). Made-with: Cursor
krisxcrash
force-pushed
the
kw/feat/sdk-545
branch
from
7a0d1ed to
c514d75
Compare
krisxcrash
requested review from
dmortal,
hukid,
jeffredodd and
serikjensen
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable
DetailViewLayoutcomponent tosrc/components/Common/that provides the shared shell for detail views — back navigation, page header (title, subtitle, action buttons), and tabbed content layout.This is the container used by all three TimeOff ViewPolicy variants (PTO/Sick, Holiday, Unlimited), but is generic enough for other detail views in the SDK.
Changes
DetailViewLayoutcomponent withDetailViewLayoutPropsinterfaceTabs,Button(with icon),Heading, andTextfromuseComponentContext()caret-lefticon as a stand-in untilarrow-leftis added via SDK-533src/components/Common/index.tsRelated
arrow-lefticon pending, usingcaret-leftstand-in)Testing
npx tsc --noEmit)