Skip to content

fix: hide date range in PayrollExecutionFlow for dismissal payrolls#1399

Draft
jeffredodd wants to merge 1 commit intomainfrom
fix/hide-dismissal-payroll-date-range
Draft

fix: hide date range in PayrollExecutionFlow for dismissal payrolls#1399
jeffredodd wants to merge 1 commit intomainfrom
fix/hide-dismissal-payroll-date-range

Conversation

@jeffredodd
Copy link
Copy Markdown
Contributor

Summary

  • Dismissal payrolls (offCycleReason === "Dismissed employee") don't have a meaningful pay period date range
  • Hides the date range from the page description/subtitle, configuration breadcrumb label, and cancel dialog title when the payroll is a dismissal payroll
  • Adds isDismissalPayroll() helper and date-free i18n keys, threads the flag through PayrollExecutionFlow to dynamically select breadcrumb labels

Test plan

  • Verify dismissal payroll Configuration page shows "Dismissed employee payroll" without dates
  • Verify dismissal payroll Overview page shows "Dismissed employee payroll" without dates
  • Verify dismissal payroll cancel dialog shows "Cancel payroll?" without dates
  • Verify dismissal payroll breadcrumb shows "Edit Payroll" without dates
  • Verify regular and other off-cycle payrolls still show dates in all locations
  • Existing payrollExecutionMachine tests pass (15/15)

Made with Cursor

Dismissal payrolls don't have a meaningful pay period date range, so
remove it from the page description, breadcrumb labels, and cancel
dialog title when offCycleReason is "Dismissed employee".

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant