fix: hide date range in PayrollExecutionFlow for dismissal payrolls#1399
Draft
jeffredodd wants to merge 1 commit intomainfrom
Draft
fix: hide date range in PayrollExecutionFlow for dismissal payrolls#1399jeffredodd wants to merge 1 commit intomainfrom
jeffredodd wants to merge 1 commit intomainfrom
Conversation
Dismissal payrolls don't have a meaningful pay period date range, so remove it from the page description, breadcrumb labels, and cancel dialog title when offCycleReason is "Dismissed employee". Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offCycleReason === "Dismissed employee") don't have a meaningful pay period date rangeisDismissalPayroll()helper and date-free i18n keys, threads the flag throughPayrollExecutionFlowto dynamically select breadcrumb labelsTest plan
payrollExecutionMachinetests pass (15/15)Made with Cursor