Skip to content

fix: [SDK-605] stop sending checkDate in dismissal payroll creation #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffredodd merged 2 commits into from
Mar 30, 2026
Merged

fix: [SDK-605] stop sending checkDate in dismissal payroll creation #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c4a044
fix: [SDK-605] use fallback check date for past-dated dismissal payrolls
jeffredodd Mar 27, 2026
6e3c654
fix: [SDK-605] stop sending checkDate in dismissal payroll creation
jeffredodd Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...onents/Payroll/Dismissal/DismissalPayPeriodSelection/DismissalPayPeriodSelection.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ describe('DismissalPayPeriodSelection', () => {
})
})

it('sends the period checkDate when available', async () => {
it('does not send checkDate so the server computes it', async () => {
const user = userEvent.setup()
mockCreateOffCyclePayroll.mockResolvedValueOnce({
payrollUnprocessed: { payrollUuid: 'new-payroll-123' },
Expand All @@ -188,7 +188,7 @@ describe('DismissalPayPeriodSelection', () => {
})

const call = mockCreateOffCyclePayroll.mock.calls[0]![0]
expect(call.request.requestBody.checkDate).toBeDefined()
expect(call.request.requestBody.checkDate).toBeUndefined()
})
})

Expand Down Expand Up @@ -233,7 +233,7 @@ describe('DismissalPayPeriodSelection', () => {
})

describe('payroll creation with missing checkDate', () => {
it('computes a fallback checkDate when period has no checkDate', async () => {
it('does not send checkDate even when period has no checkDate', async () => {
mockPayPeriods = [
{
startDate: '2024-12-01',
Expand Down Expand Up @@ -262,9 +262,7 @@ describe('DismissalPayPeriodSelection', () => {
})

const call = mockCreateOffCyclePayroll.mock.calls[0]![0]
const sentCheckDate = call.request.requestBody.checkDate
expect(sentCheckDate).toBeDefined()
expect(sentCheckDate).not.toBe('2024-12-17')
expect(call.request.requestBody.checkDate).toBeUndefined()
})
})
})
8 changes: 1 addition & 7 deletions src/components/Payroll/Dismissal/DismissalPayPeriodSelection/DismissalPayPeriodSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import { useBase } from '@/components/Base/useBase'
import { componentEvents } from '@/shared/constants'
import { SDKInternalError } from '@/types/sdkError'
import { useComponentDictionary, useI18n } from '@/i18n'
import { addBusinessDays, formatPayPeriodRange } from '@/helpers/dateFormatting'
import { ACH_LEAD_TIME_BUSINESS_DAYS } from '@/components/Payroll/OffCyclePayPeriodDateForm/useOffCyclePayPeriodDateValidation'
import { formatPayPeriodRange } from '@/helpers/dateFormatting'
import type { SelectOption } from '@/components/Common/UI/Select/SelectTypes'

export interface DismissalPayPeriodSelectionProps extends BaseComponentInterface<'Payroll.Dismissal'> {
Expand Down Expand Up @@ -89,10 +88,6 @@ function Root({ companyId, employeeId, payrollId, dictionary }: DismissalPayPeri

const resolvedEmployeeId = employeeId ?? period.employeeUuid

const checkDate = period.checkDate
? new RFCDate(period.checkDate)
: new RFCDate(addBusinessDays(new Date(), ACH_LEAD_TIME_BUSINESS_DAYS))

const response = await createOffCyclePayroll({
request: {
companyId,
Expand All @@ -102,7 +97,6 @@ function Root({ companyId, employeeId, payrollId, dictionary }: DismissalPayPeri
startDate: new RFCDate(period.startDate),
endDate: new RFCDate(period.endDate),
employeeUuids: [resolvedEmployeeId],
checkDate,
},
},
})
Expand Down
Loading