fix: convert throw sites in new components to SDKInternalError#1299
Merged
serikjensen merged 1 commit intomainfrom Mar 19, 2026
Merged
fix: convert throw sites in new components to SDKInternalError#1299serikjensen merged 1 commit intomainfrom
serikjensen merged 1 commit intomainfrom
Conversation
…Selection to SDKInternalError Guard clauses inside baseSubmitHandler callbacks should use SDKInternalError so they surface as inline banners instead of crashing the component via ErrorBoundary. Made-with: Cursor
serikjensen
requested review from
dmortal,
hukid,
jeffredodd and
krisxcrash
as code owners
jeffredodd
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throw new Error(...)tothrow new SDKInternalError(...)inTransitionCreationandDismissalPayPeriodSelectioncomponentsbaseSubmitHandlercallbacks and should surface as inline banners, not ErrorBoundary crashesSDKInternalError— these components were merged to main concurrentlyChanged files
src/components/Payroll/TransitionCreation/TransitionCreation.tsx— missing payroll ID guardsrc/components/Payroll/Dismissal/DismissalPayPeriodSelection/DismissalPayPeriodSelection.tsx— no period selected, invalid period, missing payroll ID guardsTest plan
npx tsc --noEmit)npm run build)sdkError.test.ts— 14 tests passingMade with Cursor