feat: add off-cycle payroll flow skeleton and state machine#1055
Draft
jeffredodd wants to merge 4 commits intojdj/SDK-345-extract-payroll-execution-flowfrom
Draft
feat: add off-cycle payroll flow skeleton and state machine#1055jeffredodd wants to merge 4 commits intojdj/SDK-345-extract-payroll-execution-flowfrom
jeffredodd wants to merge 4 commits intojdj/SDK-345-extract-payroll-execution-flowfrom
Conversation
jeffredodd
requested review from
dmortal,
hukid,
krisxcrash and
serikjensen
as code owners
jeffredodd
force-pushed
the
jdj/SDK-345-off-cycle-flow-skeleton
branch
from
c3fa3b0 to
ea4cfc5
Compare
jeffredodd
force-pushed
the
jdj/SDK-345-extract-payroll-execution-flow
branch
2 times, most recently
from
6b6b028 to
e2d6362
Compare
Introduce the off-cycle payroll flow structure: a two-state machine (createOffCyclePayroll -> done), flow orchestrator that transitions into PayrollExecutionFlow, breadcrumb composition via prependBreadcrumbs, and a Storybook story for visual verification. The creation UI is a placeholder that will be fleshed out in a follow-up PR. Co-authored-by: Cursor <cursoragent@cursor.com>
Move UI components, orchestration logic, stories, and breadcrumb helpers to follow-up branch (jdj/SDK-345-off-cycle-flow-ui). Keep only the state machine, type definitions, and event constants. Co-authored-by: Cursor <cursoragent@cursor.com>
…patterns Update OffCycleFlowProps.onEvent to use OnEventType<EventType, unknown> and rewrite state machine tests to use createService/send helper pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
jeffredodd
force-pushed
the
jdj/SDK-345-off-cycle-flow-skeleton
branch
from
477d144 to
312a14e
Compare
4 tasks
Wire up the off-cycle flow skeleton with presentational components and state machine transitions. The OffCycleFlow composes PayrollExecutionFlow as a nested child flow with breadcrumb prefixing, matching the pattern used by PayrollFlow. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OffCyclePayrollFlowcomponent with a state machine to manage off-cycle payroll steps (create → payroll execution)OffCycleFlowandCreateOffCyclePayrollplaceholder components for the off-cycle flowPayrollExecutionFlowto accept an optionalonBackprop for navigation from child flowsTest plan
OffCycleFlowStorybook story renders correctlyoffCycleStateMachine.test.ts)PayrollExecutionFlowonBackcallback works when navigating back from off-cycle flowMade with Cursor