Refactor rake notifications to use Notification model#4618
Refactor rake notifications to use Notification model#4618
Conversation
- Created ReminderService to handle reminder logic and Markdown generation - Updated growstuff.rake to use ReminderService and create Notification records - Implemented NotificationsHelper#reply_link for better email navigation - Made Notification#notifiable optional to support system-wide reminders - Added unit tests for ReminderService and rake tasks Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR refactors the planting and harvest reminder notifications in
growstuff.raketo use theNotificationmodel instead of callingNotifierMailer.deliver_laterdirectly.Key changes:
ReminderService.Notificationrecords, ensuring they appear in users' on-site inboxes.Notificationmodel triggers an email automatically via itsafter_createcallback if the user has opted in.NotificationsHelperwas added with areply_linkimplementation to handle linking from emails to conversations or posts.Notificationmodel now allows an optionalnotifiableassociation, facilitating aggregate reminders that don't point to a single object.PR created automatically by Jules for task 3048820086930986872 started by @CloCkWeRX