Fix RSpec/NoExpectationExample offenses and enable cop#4562
Open
CloCkWeRX wants to merge 11 commits into
Open
Conversation
- Migrated legacy `.should` syntax to modern `expect(...).to` syntax. - Added explicit expectations to view and routing specs that were missing them. - Added basic assertions to Percy feature tests to ensure page load before snapshot. - Enabled `RSpec/NoExpectationExample` by removing it from `.rubocop_todo.yml`. - Added targeted exclusion for `spec/features/percy/percy_spec.rb` in `.rubocop.yml`. Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com>
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com>
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com>
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
CloCkWeRX
commented
Apr 26, 2026
Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses over 400
RSpec/NoExpectationExampleoffenses by migrating legacy.shouldsyntax and adding missing assertions. It also enables the cop globally while excluding pure visual regression tests that only perform snapshots.PR created automatically by Jules for task 15099476535232118328 started by @CloCkWeRX