Use credentials in Structure Query and add endpoint for testing it#630
Open
nbeatty-gpa wants to merge 10 commits into
Open
Use credentials in Structure Query and add endpoint for testing it#630nbeatty-gpa wants to merge 10 commits into
nbeatty-gpa wants to merge 10 commits into
Conversation
nbeatty-gpa
force-pushed
the
XDA-69
branch
5 times, most recently
from
846b4a7 to
2bb7ccc
Compare
clackner-gpa
requested changes
May 20, 2026
|
|
||
| string query = @" | ||
| SELECT TOP (1) *, | ||
| (SELECT assetLocation.LocationID FROM AssetLocation assetLocation WHERE assetLocation.AssetID = asset.ID) AS LocationID |
Member
There was a problem hiding this comment.
This will return many if the Asset is tied to multiple locations and throw an exception
| request.UseDefaultCredentials = true; | ||
| return true; | ||
| string responseContent = response.Content.ReadAsStringAsync().GetAwaiter().GetResult(); | ||
| Log.Error($"Structure query received 'InternalServerError' response: {responseContent}"); |
Member
There was a problem hiding this comment.
It should Log the error if you throw the exception so no need to do both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For XDA-69 - previous method of sending a structure query and processing the response did not throw an exception for unsuccessful HTTP responses, and would attempt to read unsuccessful responses as CSV. Now that credentials are being used,
GetStructureQueryis changed to use configurable credentials and check for successful response before parsing the response.An endpoint is added as well to check the success of Structure Queries through System Center.