XDA-83 Automatically enumerate a directory where the 'too many changes' error occurs#535
Open
StephenCWills wants to merge 5 commits into
Open
XDA-83 Automatically enumerate a directory where the 'too many changes' error occurs#535StephenCWills wants to merge 5 commits into
StephenCWills wants to merge 5 commits into
Conversation
…nges' error occurs
…d instead of awaiting them
Member
Author
|
It occurred to me last night that the enumeration task was awaiting the processing task, which meant that in most cases, enumeration wouldn't complete until all enumerated files had been processed by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SynchronizedTaskclass is similar conceptually to theISynchronizedOperationinterface, but it is specifically designed to manageTask<T>objects so that those operations can be awaited to see when the operation is complete. Originally, I thought I'd need this for sequential enumeration strategy, but ultimately it seems I only needed it to implement cancellation.TrackedDirectorynow has aSynchronizedTaskwhich allows the user to queue up a pending enumeration task if one is already running.TrackedDirectorywill cancel both the currently running and pending enumerations, but any enumerations that queue up after that are not cancelled.FileEnumerationStrategy.ParallelSubdirectories.VisitFileAsync(). I also added some comments to make it clearer what theLogicalThread.Join()andLogicalThread.Yield()calls are used for.