Skip to content

fix: pass in no extra flag for debug mode #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregoryConrad merged 1 commit into from
Dec 23, 2025
Merged

fix: pass in no extra flag for debug mode #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion native_toolchain_rust/lib/native_toolchain_rust.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ enum BuildMode {
/// Build in release mode; i.e., `cargo build --release`
release,

/// Build in debug mode; i.e., `cargo build --debug`
/// Build in debug mode; i.e., a regular `cargo build`
debug,
}

Expand Down
9 changes: 6 additions & 3 deletions native_toolchain_rust/lib/src/build_runner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ interface class RustBuildRunner {
:enableDefaultFeatures,
:extraCargoBuildArgs,
:extraCargoEnvironmentVariables,
buildMode: BuildMode(name: cargoBuildMode),
:buildMode,
) = config;
final crateDirectory = crateDirectoryResolver.resolveCrateDirectory(
rootPath: path.fromUri(input.packageRoot),
Expand All @@ -88,7 +88,10 @@ interface class RustBuildRunner {
toolchainChannel,
'cargo',
'build',
'--$cargoBuildMode',
...switch (buildMode) {
BuildMode.release => ['--release'],
BuildMode.debug => [],
},
'--manifest-path',
manifestPath,
'--package',
Expand All @@ -110,7 +113,7 @@ interface class RustBuildRunner {
final binaryFilePath = path.join(
outputDir,
targetTriple,
cargoBuildMode,
buildMode.name,
targetOS.libraryFileName(crateName, linkMode).replaceAll('-', '_'),
);

Expand Down
Loading