"Small" Filter UI Refactor #2902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove "factory" method
add stack parameter to get the filter off of make `clearCache()` in OreDictionaryItemFilter public
add method for getting the filter ui manager from a filter
delete ui code from filter classes delete notifiable from filter classes
don't return null in error filter
Member
|
Editing the settings of a cover as an item/from your hotbar doesn't work anymore. Any changes are lost when closing the UI. |
Member
|
Well, at least partially. It's pretty inconsistent with saving to NBT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Primarily moves code out of the filter classes and into their respective UI manager classes.
Implementation Details
mostly internal changes
delete
IFilterinterfacedelete
FilterReaderinterfaceremove stack arg in filter reader constructor
make filter constructors no arg
make filters an item component and use directly
remove dirtyNotifiable from filter classes because filter reader already handles that
rename
SimpleFilterUIManager->SimpleItemFilterUIManagerOutcome
ui code is in the ui manager class and not the filter class