Fix equals() for deposit definitions #2899
Open
+16
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`super.equals(objDeposit)` in this case is the same as `this == objDeposit`. That must be wrong because: a) how it's used in other code b) this method would be redundant
Refactored to `Object.equals()` because it's more readable
The call to `super.equals()` is wrong (see 8decd9a). The `Objects.equals()` refactoring shouldn't have any side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
It looks like there's a bug in the equals() methods for
BedrockFluidDepositDefinitionandOreDepositDefinitionwhere two objects constructed with the same value won't be equal.Implementation Details
Both methods end with a call
super.equals(other). That delegates toObject.equals()which is basically the same asthis == other. This can't be right -- if the current behavior is correct, just delete both equals() overrides.I also used some calls to Objects.equals() to clean up the code, but that shouldn't have any change at runtime.
I'm guessing that this doesn't matter too much in practice, but I was just poking around the code and it bugged me.
Potential Compatibility Issues
I don't think so