Improve CraftingComponent API #2813
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
reviewed
Jun 29, 2025
Comment on lines
260
to
273
| ASSEMBLER_RECIPES.recipeBuilder().duration(80).EUt(VA[HV]) | ||
| .inputs(MetaItems.COVER_SCREEN.getStackForm()) | ||
| .inputs((ItemStack) CraftingComponent.HULL.getIngredient(1)) | ||
| .inputs((ItemStack) CraftingComponents.HULL.getIngredient(1)) | ||
| .input(wireFine, AnnealedCopper, 8) | ||
| .fluidInputs(Polyethylene.getFluid(L)) | ||
| .outputs(MetaTileEntities.MONITOR_SCREEN.getStackForm()) | ||
| .buildAndRegister(); | ||
|
|
||
| ASSEMBLER_RECIPES.recipeBuilder().duration(100).EUt(VA[HV]) | ||
| .inputs(MetaItems.COVER_SCREEN.getStackForm()) | ||
| .inputs((ItemStack) CraftingComponent.HULL.getIngredient(3)) | ||
| .inputs((ItemStack) CraftingComponents.HULL.getIngredient(3)) | ||
| .input(circuit, MarkerMaterials.Tier.HV, 2) | ||
| .fluidInputs(Polyethylene.getFluid(L)) | ||
| .outputs(MetaTileEntities.CENTRAL_MONITOR.getStackForm()) |
Contributor
There was a problem hiding this comment.
should the 1 and 3 here for getIngredient() use LV and HV instead?
Zorbatron
reviewed
Jul 2, 2025
| * @param tier the tier of the ingredient | ||
| * @return the raw ingredient, which may be either an {@link ItemStack} or {@link String} | ||
| */ | ||
| public @Nullable Object getIngredient(int tier) { |
Member
There was a problem hiding this comment.
Should there be a getItemStack(int tier) method to directly get the tier's item stack so there's no need to cast this method? A getString(int tier) would be good too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves CraftingComponent to a dedicated API class, and adds a type-safe builder method to create them.
The explicit builder methods restrict the potential ways to represent a crafting ingredient, preventing use of the more esoteric ones allowed in crafting recipes. This paves the way to expand CraftingComponent's use to more than just crafting in the future.
Implementation Details
The only significant behavioral change is that the fallback value is now handled slightly differently. Additionally, specifying a
Blockwithout meta now defaults to the wildcard metadata value instead of0. This aligns better with the expectation that a block without a specific variant specified should accept any variant.Outcome
Improves CraftingComponent code quality and API.