Add Config Option for deterministic Ore Processing #2641
Conversation
In some versions of Gregtech (including GTNH iirc), ore processing does not involve chanced outputs (excluding the sifter). I've added a config option for the people preferring that option over the way involving chances. That prevents the hassle of needing to remove and add a ton of recipes via groovy or craft tweaker.
Zorbatron
left a comment
Zorbatron
left a comment
There was a problem hiding this comment.
Looks good except for a couple balancing issues.
Also, since the new bauxite line is sort of part of ore processing, it should probably get un-chanced too.
| .input(crushedPrefix, material) | ||
| .fluidInputs(washedInTuple.getKey().getFluid(washedInTuple.getValue())) | ||
| .outputs(crushedPurifiedOre) | ||
| .output(OrePrefix.dustTiny, washingByproduct, 7 * property.getByProductMultiplier()) |
There was a problem hiding this comment.
Should this be 6 * ...? 70% of 9 is 6.3. Or are you just always rounding up to the next integer.
| .input(purePrefix, material) | ||
| .outputs(dustStack) | ||
| .output(OrePrefix.dustTiny, separatedMaterial.get(0)) | ||
| .outputs(separatedStack2) |
There was a problem hiding this comment.
This will make the yield of the secondary output much higher than the chanced version.
If the 2nd separated stack is a dust, it should output 1 tiny dust instead (will still be about 2x the yield).
Not much you can do about nuggets, except maybe making it output 1 instead of 2. Ie, 2 nuggets at 20% -> always getting 2 nuggets is quite the jump. (I guess it might make the EM separator good though 🧌)
| ItemStack dustStack = OreDictUnifier.get(OrePrefix.dust, material); | ||
| ItemStack byproductStack = OreDictUnifier.get(OrePrefix.dust, property.getOreByProduct(2, material), 1); | ||
| if (ConfigHolder.recipes.deterministicOreProcessing) { | ||
| byproductStack = OreDictUnifier.get(OrePrefix.dustTiny, property.getOreByProduct(2, material), 2); |
There was a problem hiding this comment.
Same thing here, 14% of 9 is 1.26.
| ItemStack byproductStack = OreDictUnifier.get(OrePrefix.dust, byproductMaterial); | ||
|
|
||
| if (ConfigHolder.recipes.deterministicOreProcessing) { | ||
| byproductStack = OreDictUnifier.get(OrePrefix.dustTiny, byproductMaterial, 2); |
2 participants
What
In some versions of Gregtech (including GTNH iirc), ore processing does not involve chanced outputs (excluding the sifter). I've added a config option for the people preferring that option over the way involving chances. That prevents the hassle of needing to remove and add a ton of recipes via groovy or craft tweaker.
Outcome
People can choose which way they prefer via a config.