Pipe colouring #2368
Closed
Pipe colouring #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| boolean painted = false; | ||
| while (connectedTe instanceof IPipeTile<?, ?>connectedPipe && count < MAX_PIPE_TRAVERSAL_LENGTH) { | ||
| if (connectedPipe.getPaintingColor() != (this.color == null ? -1 : this.color.colorValue)) { | ||
| connectedPipe.setPaintingColor(this.color == null ? -1 : this.color.colorValue); |
Contributor
There was a problem hiding this comment.
The color is already null checked in the constructor, so I don't think it needs to be done here.
Member
Author
There was a problem hiding this comment.
isnt this.color null for solvent spray?
the null check in the constructor is for the colour of the durability gradient
src/main/java/gregtech/common/items/behaviors/ColorSprayBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/items/behaviors/ColorSprayBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/items/behaviors/ColorSprayBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/items/behaviors/ColorSprayBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/items/behaviors/ColorSprayBehavior.java
Outdated
Show resolved
Hide resolved
TechLord22
reviewed
Apr 4, 2024
src/main/java/gregtech/common/items/behaviors/ColorSprayBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/pipelike/PipeCollectorWalker.java
Outdated
Show resolved
Hide resolved
brachy84
reviewed
Apr 5, 2024
src/main/java/gregtech/common/pipelike/PipeCollectorWalker.java
Outdated
Show resolved
Hide resolved
Contributor
ALongStringOfNumbers
left a comment
ALongStringOfNumbers
left a comment
There was a problem hiding this comment.
Hm, this is off by 1 one use. If I have a spray can with 3 uses remaining, it paints 4 pipes.
For a spraycan with 1 use left, it walks once in each connected pipe direction
Member
|
Superseded by #2858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the ability for spray cans to mass colour pipenets when shift-clicked, up until a branch
Implementation Details
When the player is crouching and holding a spraycan over a pipe, the machine grid is show, which allows for the player to select which direction to colour. This is achieved
Outcome
The player can now colour pipes in a build nicer
Additional Information
2024-01-30.18-35-01.mp4
Potential Compatibility Issues
hasPipeCollisionChangingIteminBlockPipenow takes a nullable entity but an overload was added to retain compatability