Skip to content

Clean up jade provider classes#4860

Merged
gustovafing merged 5 commits into
1.20.1from
gus/jade-providers
May 22, 2026
Merged

Clean up jade provider classes#4860
gustovafing merged 5 commits into
1.20.1from
gus/jade-providers

Conversation

@gustovafing
Copy link
Copy Markdown
Member

What

  • Make jade providers cleaner by adding MachineInfoProvider and MachineTraitProvider abstract classes for general machine information and machine trait information respectively.
  • Remove a bunch of instance checks from all providers, as they previously accepted any block/BE instead of only specific ones.
  • Change jade registration to only register providers for the appropriate block/BE, instead of registering them to be applied to the base Block and BlockEntity classes

How Was This Tested

Tested most providers in game, they retain same order as previously and seem to all work

@gustovafing gustovafing requested a review from a team as a code owner May 22, 2026 01:08
@github-actions github-actions Bot added 1.20.1 Tests: Passed Game Tests have passed on this PR labels May 22, 2026
@gustovafing gustovafing added type: refactor Suggestion to refactor a section of code Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels May 22, 2026
@gustovafing gustovafing merged commit 3c85b63 into 1.20.1 May 22, 2026
5 of 7 checks passed
@gustovafing gustovafing deleted the gus/jade-providers branch May 22, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants