Readd KubeJS GT registry event#4826
Open
screret wants to merge 20 commits into
Open
Conversation
htmlcsjs
reviewed
May 11, 2026
Member
htmlcsjs
left a comment
htmlcsjs
left a comment
There was a problem hiding this comment.
very cursory skim of the code, just some things that looked off to me. Further testing is needed but idk how much is warranted here vs full scale integration tests when 1.21 is much closer to releasing
gustovafing
added
ignore changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds back
GTCEuStartupEvents.registry.Implementation Details
A plain copy of the existing KubeJS registry event with
KubeResourceLocationswitched out forGTResourceLocationso it defaults to the GT namespace unless otherwise specified.The registry event handler class, which is also copied from KubeJS, also contains some additional handing for our special wrapper builders.
Outcome
@Ghostipedia can be happy again
How Was This Tested
The script I used for testing
Potential Compatibility Issues
GTRecipeTypes.register(String, String, RecipeType...)is now protected, as it forced addons to either register their recipe types to the GT namespace implicitly or copy the function. Use the newregister(ResourceLocation, String, RecipeType...)method instead.