Fix display voltage of WorkableElectricMultiblockMachine#4606
Open
TonyCrane wants to merge 1 commit intoGregTechCEu:1.20.1from
Open
Fix display voltage of WorkableElectricMultiblockMachine#4606TonyCrane wants to merge 1 commit intoGregTechCEu:1.20.1from
TonyCrane wants to merge 1 commit intoGregTechCEu:1.20.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set the display voltage of
WorkableElectricMultiblockMachineto the max voltage of all energy hatch parts by getting the voltage one by one instead of getting the output voltage ofEnergyContainerList.Implementation Details
#4462 use
getEnergyContainer().getOutputVoltage()to get the highest output voltage in order to support more energy hatch types (like laser). But the result ofgetEnergyContainer()is an instance ofEnergyContainerListwhose outputVoltage is re-calculated by both voltage and amperage of all energy containers of this machine. Resulting the voltage is not actually the voltage of the hatch tier.Outcome
The expected behavior and the actual outcome is the same as #4002.